Fix nomination-list in assignment poll track usage #4115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianjoel
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Could you actually reproduce the issue and verify that it was solved with this?
From the angular docs I only read that using bad values could impact performance. The placement of objects in these track parameters was done by the automatic migration. Normally these should not break anything without at least a note in the migration guide.
...ssignment-poll/components/assignment-poll-meta-info/assignment-poll-meta-info.component.html
Outdated
Show resolved
Hide resolved
...ssignment-poll/components/assignment-poll-meta-info/assignment-poll-meta-info.component.html
Outdated
Show resolved
Hide resolved
|
Yes, in my test the problems were fixed thru the track improvement. |
|
I could reproduce the problem with following the steps description. Also saw a lot of errors about the wrong 'track' behavior. After fixing the track problems, the bug was also gone. |
bastianjoel
approved these changes
Sep 13, 2024
Elblinator
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4094