Try to fix model request subscribeTo: missing unusedSubscriptions #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianjoel
requested changes
Oct 11, 2024
There was a problem hiding this comment.
The error happens because there is a meeting specific subscription that is missing a unused subscription. Please fix this instead of just suppressing the error message.
Also please log a warning to the console if subscription.unusedSubscription is undefined at that place.
|
Also PLEASE improve you PR naming. The title does not provide any helpful information. Something like "Fix model request |
reiterl
changed the title
|
@bastianjoel What is this unusedSubscriptions for? In the interface the field is optional. |
|
Added a warning to the modelRequestService. The problematic subscription is |
bastianjoel
approved these changes
Oct 18, 2024
Co-authored-by: Bastian Rihm <[email protected]>
Elblinator
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4240
The
subscription.unusedSubscriptionshere can be undefined, now the code can handle it.