Add svg files as header option in pdf export #4443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianjoel
requested changes
Dec 9, 2024
| @@ -313,7 +313,7 @@ export class MotionViewComponent extends BaseMeetingComponent implements OnInit, | |||
| /** | |||
| * Click handler for the pdf button | |||
| */ | |||
| public downloadPdf(): void { | |||
| public async downloadPdf(): Promise<void> { | |||
There was a problem hiding this comment.
This is unnecessary
Suggested change
| public async downloadPdf(): Promise<void> { | |
| public downloadPdf(): void { |
Comment on lines
329
to
338
| this.updateHeader([`pdf_header_l`, `pdf_header_r`]).then(() => { | ||
| this.mediaManageService | ||
| .getLogoUrlObservable(`pdf_header_l`) | ||
| .pipe(distinctUntilChanged()) | ||
| .subscribe(_ => this.updateHeader([`pdf_header_l`])); | ||
| this.mediaManageService | ||
| .getLogoUrlObservable(`pdf_header_r`) | ||
| .pipe(distinctUntilChanged()) | ||
| .subscribe(_ => this.updateHeader([`pdf_header_r`])); | ||
| }); |
There was a problem hiding this comment.
I don't really like this. This results in unnecessary traffic for most users when using svgs.
bastianjoel
requested changes
Jan 10, 2025
Comment on lines
335
to
339
| const downloads = await this.httpService.downloadAsBase64(url); | ||
| const svg = downloads.type === `image/svg+xml`; | ||
| if (svg) { | ||
| const fetchResult = await fetch(url); | ||
| const text = await fetchResult.text(); |
There was a problem hiding this comment.
You are downloading the image twice.
Comment on lines
384
to
386
| } else { | ||
| return -1; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } else { | |
| return -1; | |
| } | |
| } | |
| return -1; |
Comment on lines
368
to
374
| let viewBox: string = ``; | ||
| const width: number = this.getSizeValue(text, `width="`); | ||
| const height: number = this.getSizeValue(text, `height="`); | ||
| if (width !== -1 && height !== -1) { | ||
| viewBox = ` viewBox=" 0 0 ` + (width + 100) + ` ` + (height + 100) + `" `; | ||
| } | ||
| return viewBox; |
There was a problem hiding this comment.
Suggested change
| let viewBox: string = ``; | |
| const width: number = this.getSizeValue(text, `width="`); | |
| const height: number = this.getSizeValue(text, `height="`); | |
| if (width !== -1 && height !== -1) { | |
| viewBox = ` viewBox=" 0 0 ` + (width + 100) + ` ` + (height + 100) + `" `; | |
| } | |
| return viewBox; | |
| const width: number = this.getSizeValue(text, `width="`); | |
| const height: number = this.getSizeValue(text, `height="`); | |
| if (width !== -1 && height !== -1) { | |
| return ` viewBox=" 0 0 ` + (width + 100) + ` ` + (height + 100) + `" `; | |
| } | |
| return ``; |
bastianjoel
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3586