-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add live vote register to motion/assignment-poll-detail #4565
base: main
Are you sure you want to change the base?
Conversation
The first draft already looks good, but some changes are necessary:
|
I chatted with @MSoeb and looked into the code. |
The current implementation uses the new |
I have worked on the different parts:
Please have a look on this. |
entries.push({ | ||
id: user.id, | ||
user: user, | ||
voted_verbose: `voted:true`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to always be voted:true
?
If no, fix it. If yes, you may as well remove this property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
It seems to be used from the search field and seems to be a kind of power feature. So I added it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are required.
- Please use the existing column (tab) design with 'Single Votes' and 'Entitled users'. A separate view, as currently available, is not required. (relevant part in image: lower red square.)
- Additionally more information is needed under the progress bar. Please add information about entitled users and present entitled users with numbers (see red marked area under the progress bar). Please take care, the numbers are not static and should change like the corresponding numbers does. The text should be right-alinged to the progress bar. The color should be gray, just like the words 'orange, schwarz' in the image. The information should be written in german in the following way:
- Stimmberechtige anwesend: [right number of progress bar]
- Stimmberechtigte gesamt: [number of entitled users]
To point 1. I rebuild the tab structure of the single votes and entitled users. |
Yes, this was not previously a requirement. However, this has changed. It is now a requirement. Please integrate it. Explanation: Further information: |
I think, the logic with the progress bar should be handled in another issue. I will exclude the poll-progress here, because it includes misleading information. |
The poll progress bar seems to deliver wrong info in this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The progress was a required element in this view. please readd it.
I removed the poll progress part. It should be handled in another issue, I suppose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found different points, that needs to be fixed or improved:
- By opening the entitled users tab (red square in image) during a live poll, an error appears in the console. -> Wanted behavior: Please fix error.
- The numbers in the progress bar and in the information beneath it doesn't match. (see examples in red squares). They don't match, because the lower number doesn't include vote delegations. -> Wanted behavior: Vote delegations should be included in the number 'present people allowed to vote. Both numbers should always match.
- Re-Positioning of the new information (marked relevant content in image). Please place the information more next to the progress bar (marked with green) . It should have more space to the content below.
- Re-Positioning of 'No data avilable'. The current position is not optimal. PLease please it, if possible, in the middle aligned to the word above. I've marked a possible area with green.
This needs to be done to fix an error.
One other version of the the live vote register. Please test. |
Resolve #3986
First draft version.
Needs:
OpenSlides/openslides-autoupdate-service#1118
OpenSlides/openslides-vote-service#308
Reuse of the entitled-users-table.