Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchors #69

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Add anchors #69

merged 5 commits into from
Apr 19, 2024

Conversation

bastianjoel
Copy link
Member

Closes #12

@bastianjoel
Copy link
Member Author

Search service supports this now: OpenSlides/openslides-search-service#78

Copy link
Contributor

@jsangmeister jsangmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not recycle #12? But it's fine either way

@jsangmeister jsangmeister added the enhancement General enhancement which is neither bug nor feature label Apr 4, 2024
@jsangmeister jsangmeister added this to the 4.2 milestone Apr 4, 2024
@jsangmeister
Copy link
Contributor

Do the changes from OpenSlides/openslides-search-service#78 also have to be included in the AU before we merge this?

@bastianjoel
Copy link
Member Author

@ostcar Do you want to adopt the changes?

@ostcar
Copy link
Member

ostcar commented Apr 5, 2024

I am not sure. If go generate ./... works, and the tests pass, then it can be merged. If not, I have to make some changes.

Do you want to test this? I am not sure, If I find the time this weekend.

@jsangmeister
Copy link
Contributor

As suspected, does not work:

2024/04/05 10:42:47 Can not parse model definition: unmarshalling models.yml: decoding models: field object without type: [1:1] sequence was used where mapping is expected
        >  1 | &languages
               ^
           2 |     - en
           3 |     - de
           4 |     - it
           5 |     

@bastianjoel can you port the changes? Or can the code be reused somehow, maybe in the common package which AU and ICC also use?

@bastianjoel
Copy link
Member Author

I will port the changes.

@jsangmeister jsangmeister merged commit bed1e56 into OpenSlides:main Apr 19, 2024
1 check passed
@bastianjoel bastianjoel deleted the add-anchors branch April 19, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants