Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Addition of Extra User Fields #46

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

AyakorK
Copy link
Contributor

@AyakorK AyakorK commented Jul 18, 2024

🎩 Description

Please describe your pull request.

This PR adds the module Extra User Fields to the CDC and modifies a bit the create_registration command to ensure the compatibility between the custo previously made and this module

📌 Related Issues

Testing

Describe the best way to test or validate your PR.

💾 Back Office Setup

  • Before launching your app make sure you precompiled Deface to ensure the fields appears in the registration form by running bundle exec rake deface:precompile
  • Access to Back Office
  • Click on Settings
  • Access EUF settings
  • Enable any field you want

🖼️ Front Office Test

  • As a disconnected user, click on the Register Button
  • Make sure that your previously added extra user fields are appearing correctly
  • Fill in your form and submit it
  • Make sure you can register easily without any crash
  • Check your mails if you receive correctly mails (Make sure to activate Underage Field if you want to have the statutory representative email at the end)

Tasks

  • Add specs
  • Import the create_registration_command from EUF to fix the issue of Email Representative (not working we need to figure out why)
  • Addition of few migrations related to EUF

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

@luciegrau luciegrau self-requested a review July 19, 2024 15:03
@luciegrau luciegrau marked this pull request as ready for review July 22, 2024 08:36
Copy link

@BarbaraOliveira13 BarbaraOliveira13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it, and I have the extra user fileds that repeat twice (@luciegrau I am the only one ? :s) :
Capture d’écran 2024-07-22 à 11 24 17
Capture d’écran 2024-07-22 à 11 44 39

Other than this, it works great when I register 👍

I don't know if it's necessary to spend time on it...just a suggestion: add an 's' to 'Plus d'informations' when there are more than 2 fields ? 🤷‍♀️

@AyakorK
Copy link
Contributor Author

AyakorK commented Jul 22, 2024

I ran it, and I have the extra user fileds that repeat twice (@luciegrau I am the only one ? :s) : Capture d’écran 2024-07-22 à 11 24 17 Capture d’écran 2024-07-22 à 11 44 39

Other than this, it works great when I register 👍

I don't know if it's necessary to spend time on it...just a suggestion: add an 's' to 'Plus d'informations' when there are more than 2 fields ? 🤷‍♀️

Heyy for the first issue this might be an issue related to Deface and the precompilation of it. Check if you have a local folder named "compiled_views" and try to delete it and to run it again if you want to try !

Otherwise for the other issue yeah this might be something to fix but that is actually on the module itself ! Let's wait for Lucie's answer to see if this is something important to fix

@luciegrau
Copy link
Contributor

Hi @BarbaraOliveira13 and @AyakorK!
I didn't get the same error as Barbara when I launched the PR locally, I think it was linked to Deface.
As for Barbara's suggestion for improvement, I agree with her. This has already been pointed out by some clients and we could implement this change directly in the extra user fields module.
However, there's no need to wait for this improvement to bump the module to decidim-cdc since they're only going to activate the phone number field.

@BarbaraOliveira13
Copy link

I ran it, and I have the extra user fileds that repeat twice (@luciegrau I am the only one ? :s) : Capture d’écran 2024-07-22 à 11 24 17 Capture d’écran 2024-07-22 à 11 44 39
Other than this, it works great when I register 👍
I don't know if it's necessary to spend time on it...just a suggestion: add an 's' to 'Plus d'informations' when there are more than 2 fields ? 🤷‍♀️

Heyy for the first issue this might be an issue related to Deface and the precompilation of it. Check if you have a local folder named "compiled_views" and try to delete it and to run it again if you want to try !

Otherwise for the other issue yeah this might be something to fix but that is actually on the module itself ! Let's wait for Lucie's answer to see if this is something important to fix

Ok I will try again asap to understand ;) but it's just me, obviously. Great job! And thanks for the details :)

@Quentinchampenois Quentinchampenois merged commit 171ec53 into develop Jul 22, 2024
14 checks passed
@Quentinchampenois Quentinchampenois deleted the feat/extra_user_fields branch July 22, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants