-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Addition of Extra User Fields #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran it, and I have the extra user fileds that repeat twice (@luciegrau I am the only one ? :s) :
Other than this, it works great when I register 👍
I don't know if it's necessary to spend time on it...just a suggestion: add an 's' to 'Plus d'informations' when there are more than 2 fields ? 🤷♀️
Heyy for the first issue this might be an issue related to Deface and the precompilation of it. Check if you have a local folder named "compiled_views" and try to delete it and to run it again if you want to try ! Otherwise for the other issue yeah this might be something to fix but that is actually on the module itself ! Let's wait for Lucie's answer to see if this is something important to fix |
Hi @BarbaraOliveira13 and @AyakorK! |
Ok I will try again asap to understand ;) but it's just me, obviously. Great job! And thanks for the details :) |
🎩 Description
Please describe your pull request.
This PR adds the module Extra User Fields to the CDC and modifies a bit the create_registration command to ensure the compatibility between the custo previously made and this module
📌 Related Issues
Testing
Describe the best way to test or validate your PR.
💾 Back Office Setup
bundle exec rake deface:precompile
🖼️ Front Office Test
Register
ButtonTasks
📷 Screenshots
Please add screenshots of the changes you're proposing if related to the UI