fix: CleanInactiveUsersJob fails on Active Record validation fail

[Quentinchampenois]

Description

If a user isn't valid, CleanInactiveUsersJob task will continuously fail, this is due to the command Decidim::DestroyAccount which attempts to invalidate_all_sessions before updating user's attributes.

Related to

• Notion : https://www.notion.so/opensourcepolitics/Toulouse-Decidim-cleaner-jobs-are-failing-9e74e006a00741b7b2b5fdf3c6433b3c?pvs=4

Testing

• Create multiple users with different current_sign_in_at
• Run command bundle exec rake decidim_cleaner:clean_inactive_users
• It should send email to concerned users

If you want to test the fix

• Force a user attribute to a value that does not pass validations : (nickname: "####")
• Run task
• It should run without errors

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3b7ee7) 89.69% compared to head (2df64db) 90.69%.
Report is 13 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop      #40      +/-   ##
===========================================
+ Coverage    89.69%   90.69%   +1.00%     
===========================================
  Files           14       15       +1     
  Lines          194      215      +21     
===========================================
+ Hits           174      195      +21     
  Misses          20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AyakorK]

Works great for me !