Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove not needed form_builder override #37

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

Quentinchampenois
Copy link
Contributor

@Quentinchampenois Quentinchampenois commented Mar 6, 2024

Description

Override breaks the editor image uploader in Quill.JS editor

Related to : #11
Fixes: #38

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (1a054fa) to head (bcf2f09).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #37       +/-   ##
===========================================
+ Coverage   67.60%   98.49%   +30.88%     
===========================================
  Files          14       13        -1     
  Lines         639      265      -374     
===========================================
- Hits          432      261      -171     
+ Misses        207        4      -203     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luciegrau luciegrau merged commit f0218ac into main Mar 8, 2024
8 checks passed
@luciegrau luciegrau deleted the fix/image_editor branch March 8, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quill.js can't upload image
2 participants