Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add newsletter modal to the register page #168

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

AyakorK
Copy link
Contributor

@AyakorK AyakorK commented Nov 21, 2023

🎩 Description

Previously added, the newsletter was working pretty well, but a feature that was important, the appearance of a modal as a reminder to check the newsletter wasn't appearing. This PR fixes that and add some tests about it.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Example:

  • Try to Register
  • Don't check the newsletter
  • Fill in other fields
  • See the appearance of the modal
  • Proceed to register afterwards and check that there is no issue

Tasks

  • Add specs
  • Add JS to the appearance of the modal

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

@AyakorK AyakorK marked this pull request as ready for review November 22, 2023 14:47
@AyakorK AyakorK requested a review from a team November 22, 2023 14:47
@Quentinchampenois Quentinchampenois merged commit 1ff9a9f into develop Nov 22, 2023
13 checks passed
@Quentinchampenois Quentinchampenois deleted the fix/readd_newsletter_modal branch November 22, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants