Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add layer of security and download p7zip-full lib on docker #237

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

AyakorK
Copy link
Contributor

@AyakorK AyakorK commented Sep 25, 2024

🎩 Description

This PR adds the library p7zip-full to the dockerfile to fix the issue of the data that were not exporting on user profile.
This also adds a layer of security to the code to ensure to generate the file if it doesn't exist to avoid errors.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

TO SETUP YOUR APP

  • Please use DOCKER you absolutely need it
  • If you already had setup a docker instance of decidim-tou in the past please run make teardown
  • If you want to be sure you can run make build
  • Run the command make run to setup your app
  • Once it's setup please make sure you access to your platform using the url https://localhost:3000

TEST THE FEATURE

  • Log in as a user (or admin)
  • Access to your profile using "My Account" button
  • Access "Download your data"
  • Hit the button
  • Access https://localhost:3000/letter_opener
  • Make sure you received the mail with your data

IF YOU RECEIVED IT

  • Please open your folder using the password in the mail
  • Make sure everything works correctly and that you received all your data

IF YOU DIDN'T RECEIVE IT

  • Please access https://localhost:3000/sidekiq
  • Log as [email protected]
  • Access to your retries and provide us the error

Tasks

  • Modify Dockerfile and Dockerfile.local to add p7zip-full
  • Modify the service to add a layer of security

@AyakorK AyakorK marked this pull request as ready for review September 25, 2024 09:40
@luciegrau luciegrau merged commit 94be0ad into develop Sep 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants