Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix Half Signup that is not working properly #238

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: Fix Half Signup that is not working properly #238

merged 1 commit into from
Oct 3, 2024

Conversation

AyakorK
Copy link
Contributor

@AyakorK AyakorK commented Oct 2, 2024

🎩 Description

We move the gem below Budgets booth as it needs to overwrite some features of it.

📌 Related Issues

Testing

Example:

  • Log in as admin
  • Access Backoffice
  • Go to organization settings
  • Go to authentication settings
  • Enable Authentication using SMS on Half Signup
  • Go back to front office
  • Access a participatory process
  • Access a budget
  • Try to vote for it
  • Check that you are redirected to the authentication using SMS
  • Check that the behavior is working properly from beginning to end

Tasks

  • Fix gem order
  • Bump HalfSignup

@AyakorK AyakorK marked this pull request as ready for review October 2, 2024 15:07
@AyakorK AyakorK requested a review from luciegrau October 2, 2024 15:07
@luciegrau luciegrau merged commit cad04d3 into develop Oct 3, 2024
14 checks passed
@luciegrau luciegrau deleted the fix/repair_half_signup branch October 3, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luciegrau luciegrau luciegrau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyakorK @luciegrau