Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logos to match accessibility #1237

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

AyakorK
Copy link

@AyakorK AyakorK commented Dec 3, 2024

🎩 What? Why?

This PR change logos from footer and header to be RGAA compliant, as the alt of the footer wasn't on the last changes from the header, and the header had an aria-label which wasn't accessible because hid the alt of the logo.

Testing

Describe the best way to test or validate your PR.

  • Go to back office
  • Go to organization settings
  • Add a logo to your application and a footer logo
  • Go back to the main page
  • Make sure they have the same alt
  • Make sure the aria-label has been deleted

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@AyakorK AyakorK changed the title fix(rgaa): change logos to match accessibility hange logos to match accessibility Dec 3, 2024
@AyakorK AyakorK changed the title hange logos to match accessibility Change logos to match accessibility Dec 3, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant