Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing locale blocking the JS #1238

Closed
wants to merge 1 commit into from

Conversation

AyakorK
Copy link

@AyakorK AyakorK commented Dec 6, 2024

🎩 What? Why?

This missing locale was blocking the loading of the text editor on the participatory processes

📌 Related Issues

How to test

  • First of all you may add the french locale as an available locale !
  • Create a development app
  • Go through the config/decidim.rb in your development_app and change line 17 by config.available_locales = %w(en ca es fr)
  • Execute bundle exec rails c (Warning if you're using Sprint you may have to execute DISABLE_SPRING=true bundle exec rails c
  • Execute those lines in your rails console (follow the order otherwise it may not work)
org = Decidim::Organization.first
org.available_locales+=["fr"]
org.save!
exit

You're all set now so next step :

  • Log as an admin
  • Navigate through the Back Office
  • Try to access processes and to create a new one or update an existing one
  • Make sure you're on "french" locale
  • Make sure that the editor is displayed correctly and that you can freely submit your new or edit your existing process.

📋 Subtasks

  • Add missing locale (key was there but content was empty so it made the i18n.js create_dictionary function crash)

@AyakorK AyakorK changed the title fix: Add missing locale blocking the JS Add missing locale blocking the JS Dec 6, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@AyakorK AyakorK closed this Dec 9, 2024
@AyakorK AyakorK deleted the fix/text_editor_not_displaying branch December 9, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant