Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict runtime saves #1178

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Restrict runtime saves #1178

wants to merge 3 commits into from
+43 −36

Commits on Oct 4, 2024

  1. only write the config to flash when it is safe to 

    the USB host port uses the flash, as does our config. both cores
accessing the flash at the same time is no good and will crash the host
port, so the host port core is locked when writing flash for saving the
config, but this disables interrupts on the port and may interfere with
auth, so this only saves at runtime when it is safe to (when USB host is
disabled), with an optional flag to force saving the config, which
should only be used in limited circumstances.
    @bsstephan
    bsstephan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e8929ea View commit details
    Browse the repository at this point in the history

  2. always force config saves in the webconfig 

    it doesn't use the USB host port for anything so this should always be
fine
    @bsstephan
    bsstephan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2e9c124 View commit details
    Browse the repository at this point in the history

  3. add a hotkey to force a save of the config

    @bsstephan
    bsstephan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4e54d50 View commit details
    Browse the repository at this point in the history