Add macOS openURL implementation and fix test crash

OpenSwiftUIProject · Nov 28, 2023 · e52c1ca · e52c1ca
1 parent dd516ee
commit e52c1ca
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/Sources/OpenSwiftUI/DataAndStorage/EnvironmentValues/EnvironmentValues+openURL.swift b/Sources/OpenSwiftUI/DataAndStorage/EnvironmentValues/EnvironmentValues+openURL.swift
@@ -13,6 +13,8 @@ import UIKit
 private import UIKitCore
 private import CoreServices
 #endif
+#elseif os(macOS)
+import AppKit
 #endif
 #endif
 
@@ -97,10 +99,12 @@ extension EnvironmentValues {
 struct OpenURLActionKey: EnvironmentKey {
     static let defaultValue = OpenURLAction(
         handler: .system { url, completion in
-            #if os(iOS) || os(tvOS) || os(visionOS)
+            #if os(iOS) || os(tvOS)
             UIApplication.shared.open(url, options: [:], completionHandler: completion)
             #elseif os(macOS)
-            fatalError("Unimplemented")
+            NSWorkspace.shared.open(url, configuration: .init()) { application, error in
+                completion(error != nil)
+            }
             #else
             fatalError("Unimplemented")
             #endif

diff --git a/Tests/OpenSwiftUITests/DataAndStorage/EnvironmentValues/EnvironmentValuesOpenURLTests.swift b/Tests/OpenSwiftUITests/DataAndStorage/EnvironmentValues/EnvironmentValuesOpenURLTests.swift
@@ -9,9 +9,9 @@ import XCTest
 @testable import OpenSwiftUI
 
 final class EnvironmentValuesOpenURLTests: XCTestCase {
-    #if DEBUG
-    func testOpenSensitiveURLActionKey() throws {
-        let value = OpenSensitiveURLActionKey.defaultValue
+    #if os(iOS) || os(macOS) || os(tvOS)
+    func testOpenURLActionKey() {
+        let value = OpenURLActionKey.defaultValue
         value.callAsFunction(URL(string: "https://example.com")!)
     }
     #endif