Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LegacyApp and Benchmark API #25

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Add LegacyApp and Benchmark API #25

merged 5 commits into from
Jan 10, 2024

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Jan 9, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (75efab0) 16.98% compared to head (70721ef) 16.32%.

❗ Current head 70721ef differs from pull request most recent head 6b04c2d. Consider uploading reports for the commit 6b04c2d to get more accurate results

Files Patch % Lines
Sources/OpenSwiftUI/Test/_BenchmarkHost.swift 0.00% 31 Missing ⚠️
Sources/OpenSwiftUI/Test/_PerformanceTest.swift 0.00% 22 Missing ⚠️
Sources/OpenSwiftUI/Test/TestApp.swift 0.00% 12 Missing ⚠️
...iftUI/AppStructure/AppOrganization/LegacyApp.swift 0.00% 8 Missing ⚠️
Sources/OpenSwiftUI/Test/TestIDView.swift 0.00% 8 Missing ⚠️
...OpenSwiftUI/Internal/Other/EnvironmentHelper.swift 0.00% 5 Missing ⚠️
...SwiftUI/Views/View/internal/ViewRendererHost.swift 0.00% 4 Missing ⚠️
Sources/OpenSwiftUI/Test/_Benchmark.swift 0.00% 3 Missing ⚠️
Sources/OpenSwiftUI/Test/_Test.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   16.98%   16.32%   -0.66%     
==========================================
  Files         139      148       +9     
  Lines        2278     2370      +92     
==========================================
  Hits          387      387              
- Misses       1891     1983      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye merged commit c0e6e19 into main Jan 10, 2024
4 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/_app branch January 10, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants