Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimize] Remove importing CoreGraphics on Darwin for CGFloat #45

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Mar 10, 2024

Many CG related struct definition has moved from CoreGraphics to CoreFoundation.

So we can just use import Foundation for all platforms.

@Kyle-Ye Kyle-Ye changed the title 🔧 fix: remove unnecessary checks for importing CoreGraphics on non-Darwin systems [Optimize] Remove importing CoreGraphics on Darwin for CGFloat Mar 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.82%. Comparing base (02d8ca4) to head (87f466c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   16.82%   16.82%           
=======================================
  Files         161      161           
  Lines        3191     3191           
=======================================
  Hits          537      537           
  Misses       2654     2654           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye merged commit bb16769 into main Mar 10, 2024
5 checks passed
@Kyle-Ye Kyle-Ye deleted the optimize/import branch March 10, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants