Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ViewGraph implementation #58

Merged
merged 7 commits into from
Apr 4, 2024
Merged

Update ViewGraph implementation #58

merged 7 commits into from
Apr 4, 2024

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Apr 4, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 1.60428% with 184 lines in your changes are missing coverage. Please review.

Project coverage is 13.52%. Comparing base (831c079) to head (0710ebb).

Files Patch % Lines
Sources/OpenSwiftUI/Core/View/ViewGraph.swift 0.00% 95 Missing ⚠️
Sources/OpenSwiftUI/Core/Graph/GraphHost.swift 0.00% 21 Missing ⚠️
.../LayoutAdjustments/Direction/LayoutDirection.swift 0.00% 21 Missing ⚠️
...enSwiftUI/Data/Environment/CachedEnvironment.swift 0.00% 11 Missing ⚠️
...tUI/Layout/LayoutAdjustments/Edge/EdgeInsets.swift 0.00% 10 Missing ⚠️
...out/LayoutFundamentals/internal/ProposedSize.swift 30.00% 7 Missing ⚠️
...ources/OpenSwiftUI/View/Debug/TODO/ViewDebug.swift 0.00% 7 Missing ⚠️
Sources/OpenSwiftUI/Core/Data/VersionSeed.swift 0.00% 4 Missing ⚠️
...penSwiftUI/Data/Preference/PreferencesInputs.swift 0.00% 3 Missing ⚠️
Sources/OpenSwiftUI/View/View/EmptyView.swift 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   14.04%   13.52%   -0.52%     
==========================================
  Files         176      180       +4     
  Lines        3859     4029     +170     
==========================================
+ Hits          542      545       +3     
- Misses       3317     3484     +167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye merged commit 14597bb into main Apr 4, 2024
5 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/basic_view branch April 4, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants