Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SliderStyle support #6

Merged
merged 11 commits into from
Dec 16, 2023
Merged

Add SliderStyle support #6

merged 11 commits into from
Dec 16, 2023

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Dec 3, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

Attention: 339 lines in your changes are missing coverage. Please review.

Comparison is base (702ce69) 9.60% compared to head (dea3ffd) 14.35%.

Files Patch % Lines
...ces/OpenSwiftUI/Views/Controls/Slider/Slider.swift 24.38% 183 Missing ⚠️
...Accessibility/internal/AnyAccessibilityValue.swift 0.00% 59 Missing ⚠️
...I/Accessibility/internal/AccessibilityNumber.swift 0.00% 19 Missing ⚠️
.../Accessibility/internal/AccessibilityNumeric.swift 21.73% 18 Missing ⚠️
...iews/Controls/Slider/internal/AnySliderStyle.swift 0.00% 12 Missing ⚠️
...UI/Accessibility/internal/AccessibilityValue.swift 0.00% 10 Missing ⚠️
...sibility/internal/AccessibilityBoundedNumber.swift 72.41% 8 Missing ⚠️
...es/OpenSwiftUI/Views/View/internal/ViewAlias.swift 0.00% 8 Missing ⚠️
...ssibility/internal/AccessibilityValueByProxy.swift 0.00% 6 Missing ⚠️
...Modifier/internal/AccessibilityLabelModifier.swift 0.00% 4 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff            @@
##            main       #6      +/-   ##
=========================================
+ Coverage   9.60%   14.35%   +4.74%     
=========================================
  Files        107      123      +16     
  Lines       1260     1700     +440     
=========================================
+ Hits         121      244     +123     
- Misses      1139     1456     +317     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye merged commit 7481074 into main Dec 16, 2023
4 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/slider_style branch December 16, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants