Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic layout system support #7

Merged
merged 7 commits into from
Dec 17, 2023
Merged

Add basic layout system support #7

merged 7 commits into from
Dec 17, 2023

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Dec 17, 2023

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2023 •
edited
Loading

Codecov Report

Attention: 133 lines in your changes are missing coverage. Please review.

Comparison is base (7481074) 14.35% compared to head (fbe0252) 13.94%.

Files Patch % Lines
...t/LayoutFundamentals/internal/LayoutComputer.swift 0.00% 29 Missing ⚠️
...I/Layout/LayoutFundamentals/internal/Spacing.swift 0.00% 22 Missing ⚠️
...ayoutAdjustments/Alignment/VerticalAlignment.swift 0.00% 16 Missing ⚠️
...t/LayoutAdjustments/Alignment/ViewDimensions.swift 0.00% 14 Missing ⚠️
...out/LayoutAdjustments/Alignment/AlignmentKey.swift 0.00% 13 Missing ⚠️
...outAdjustments/Alignment/HorizontalAlignment.swift 0.00% 12 Missing ⚠️
...es/OpenSwiftUI/Views/View/TODO/_VariadicView.swift 0.00% 8 Missing ⚠️
...iftUI/Layout/LayoutFundamentals/Stack/HStack.swift 0.00% 7 Missing ⚠️
...OpenSwiftUI/Views/Animations/TODO/Animatable.swift 0.00% 4 Missing ⚠️
...ayout/LayoutFundamentals/Stack/_HStackLayout.swift 0.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   14.35%   13.94%   -0.41%     
==========================================
  Files         123      132       +9     
  Lines        1700     1785      +85     
==========================================
+ Hits          244      249       +5     
- Misses       1456     1536      +80

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye merged commit 5832009 into main Dec 17, 2023
2 of 4 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/layout_basic branch December 17, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Kyle-Ye