Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .spi.yml #93

Merged
merged 1 commit into from
May 15, 2024
Merged

Update .spi.yml #93

merged 1 commit into from
May 15, 2024

Conversation

finestructure
Copy link
Contributor

Don't force doc gen to run on a Swift version not supported by this package

Don't force doc gen to run on a Swift version not supported by this package
@Kyle-Ye
Copy link
Member

Kyle-Ye commented May 15, 2024

Don't force doc gen to run on a Swift version not supported by this package

Got it. So I assume SPI will pick the right version for the package here.

Image one day I update the Package.swift tool version from 5.10 to 6. Will SPI support it automatically?

@Kyle-Ye
Copy link
Member

Kyle-Ye commented May 15, 2024

Don't force doc gen to run on a Swift version not supported by this package

Aha. Thanks for catching the bug.

@finestructure
Copy link
Contributor Author

We always build docs with the latest release version of Swift unless a specific swift_version is set in the config!

@@ -1,5 +1,4 @@
version: 1
builder:
configs:
- swift_version: 5.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the version to 5.10 (I'll update the version with my Package.swift version at the same time later)?

If we should remove this field, then what scenario is this field for? I could not find other meaningful scenario of the field then.

@Kyle-Ye
Copy link
Member

Kyle-Ye commented May 15, 2024

We always build docs with the latest release version of Swift unless a specific swift_version is set in the config!

Got it. So when Swift 6 is out, the doc will be built against Swift 6 compiler(with the current language mode - Swift 5) even though the package is still using Package.swift+5.10 and Swift 5 language mode.

@Kyle-Ye Kyle-Ye merged commit 663b6ac into OpenSwiftUIProject:main May 15, 2024
6 checks passed
@finestructure finestructure deleted the patch-1 branch May 15, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants