Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead link in readme #88

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fix dead link in readme #88

merged 1 commit into from
Aug 9, 2024

Conversation

erenes
Copy link
Contributor

@erenes erenes commented Aug 6, 2024

The link to download grfcodec in the readme is dead, this PR updates the link to the currently available link on the openttd website.

@erenes
Copy link
Contributor Author

erenes commented Aug 7, 2024

I think I fixed the commit message to be the proper format, I have not been able to reverse engineer what the Annotation check does. Based on the code, I think it just checks that the workflows have run? So hopefully fixing the commit message also fixes the annotation check :)

@erenes
Copy link
Contributor Author

erenes commented Aug 8, 2024

@LordAro with #89 merged, restarting the checks for this PR should succeed :)

Edit: I had to rebase and the checks got re-run automagically, nice!

@LordAro LordAro merged commit cd7b508 into OpenTTD:master Aug 9, 2024
3 checks passed
@LordAro
Copy link
Member

LordAro commented Aug 9, 2024

Thanks for your efforts with this and #89. You're a proper contributor now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants