Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax validation #14

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Relax validation #14

merged 3 commits into from
Apr 30, 2024

Conversation

frosch123
Copy link
Member

This relaxes some of the validations:

  • Allow translations to differ in number of line breaks: Some long texts require manual breaks for formatting, which naturally differs between languages.
  • Allow duplicate usage of positional parameters, if they may name things: Sometimes it is easier for translations to repeat the name of somethings, instead of using pronouns to reference an earlier mentioning.
  • Remove "front only" validation for font sizes: This rule turned out more complicated than helpful.

With these changes there are no more false errors/warnings in the 3 test languages. (though a few true ones)

Some long texts require manual breaks for formatting.
Sometimes translations repeat names, instead of using pronouns.
This validation is not worth the hassle. Colors have similar requirements and would be even more complicated to validate.
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, feat :P I would consider it fix, but whatever :D

@frosch123
Copy link
Member Author

i wanted change, but that is not allowed

@frosch123 frosch123 merged commit b3d4a9f into OpenTTD:main Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants