Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a9a1a3e: Don't use station properties 1C/1D for IDs 00-FF #305

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Sep 26, 2023

Properties 1C/1D are supported only by OpenTTD 14+.
Also using C5xx range in prop 1C is not supported by OpenTTD.

With this PR C4xx/C5xx are always used for IDs<256 without using properties 1C/1D, and for IDs>=256 the properties are used and the strings are in DCxx range.

Fixes #311

@glx22 glx22 changed the title Fix a9a1a3e: Forget about C5xx range for station names Fix a9a1a3e: Don't use station properties 1C/1D for IDs 00-FF Oct 24, 2023
Copy link
Member

@PeterN PeterN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane enough. 255 as an ID wasn't allowed pre-extended IDs, but that is not relevant here.

@glx22 glx22 merged commit 79afbc0 into OpenTTD:master Dec 18, 2023
21 checks passed
@glx22 glx22 deleted the station_names branch December 18, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error when not providing a name property for waypoints.
2 participants