Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Support town_production_effect and town_production_multiplier. #318

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Feb 2, 2024

Provides support for town production effect and multiplier properties of OpenTTD#11947

        town_production_effect:     TOWNPRODUCTION_PASSENGERS;
        town_production_multiplier: 1.0;
        town_production_effect:     TOWNPRODUCTION_MAIL;
        town_production_multiplier: 0.75;

@PeterN PeterN force-pushed the town-production-effect branch from d18d127 to fd28e55 Compare February 3, 2024 13:30
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need confirmation it works from an NML user.

@PeterN
Copy link
Member Author

PeterN commented Feb 3, 2024

This has been tested with improved town industries, which replaces mail with waste.

@2TallTyler
Copy link
Member

2TallTyler commented Feb 8, 2024

This PR adds the new properties to ITI: 2TallTyler/improved_town_industries#104. I have not tested this NML PR.

A question: Do I need to bump the minimum required OpenTTD version for the GRF (using a custom error), or will the properties be ignored in older versions of OpenTTD?

@PeterN
Copy link
Member Author

PeterN commented Feb 8, 2024

You'll need a version check. NewGRF is not self-descriptive so older versions don't know how to skip properties they don't know.

You can do this Bananas side to make life easier, then only 14.x players will be offered a new version, though of course that doesn't stop someone manually downloading and trying to load it in an older version.

@PeterN PeterN merged commit 9b8a23f into OpenTTD:master Feb 8, 2024
21 checks passed
@PeterN PeterN deleted the town-production-effect branch September 16, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants