Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Reduce D0xx usage where possible #326

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Apr 21, 2024

D0xx range is very small, and must be used for CB results.

Some CB allow use of {STRING} and text stack in the returned D0xx, and {STRING} supports DCxx in text stack. But filling the text stack will still allocate D0xx when a DCxx is desired.

Try to detect when we might be filling text stack and use DCxx range in this case.

@PeterN
Copy link
Member

PeterN commented Apr 21, 2024

Sounds reasonable. Do we need a unit-test for this?

@glx22 glx22 merged commit 448b440 into OpenTTD:master Apr 21, 2024
21 checks passed
@glx22 glx22 deleted the reduce_D0xx branch April 21, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants