Change: Unreachable range for default only switch should target CB_FAILED #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unreachable range for default only switches should target the CB_FAILED group, instead of returning a success value of 0.
This is because the current success value of 0 interacts unfavourably with other unfortunate quirks of the GRF spec and how callbacks are handled.
The result of this is that a switch which can trigger a variable error in the graphics chain can result in unrelated callbacks inexplicably succeeding with a value of 0. In the case of callback 36 this can lead to all sorts of weird behaviour.
This PR changes this behaviour to the callbacks returning a failure result as expected.