Fix nearby_tile_same_grf, nearby_tile_other_grf and nearby_tile_original_gfx, they all compared to wrong constants
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relevant grfspec page: https://newgrf-specs.tt-wiki.net/wiki/VariationalAction2/Stations |
ahyangyi
force-pushed
the
fix-station-variables
branch
from
06f4fd7 to
216ea89
Compare
WenSimEHRP
added a commit
to OpenTTD-China-Set/china-set-stations
that referenced
this pull request
May 18, 2024
Hirundo made this mistake years ago... See OpenTTD/nml#330
|
Broken test is false alarm, should be fixed by #331... |
|
I think it would be less confusing to reorder the definitions so that the numbers are still 0, 1, 2 |
|
I wanted to begin with a minimal delta, but the new order does make sense. |
…_original_gfx`, they all compared to wrong constants
ahyangyi
force-pushed
the
fix-station-variables
branch
from
bf20b11 to
5fa78f5
Compare
glx22
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…original_gfx`, they all compared to wrong constants