Add: Support for station properties 0E and 0F #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
reviewed
Aug 15, 2024
Comment on lines
+131
to
+135
| [4, 5], | ||
| [6, 7] |
There was a problem hiding this comment.
Should this silently convert to 04 04 06 06 or throw an error?
There was a problem hiding this comment.
For now it's silently converted, but an error or a warning is possible.
|
Added warnings for non even tile types, they are still converted at the end. |
PeterN
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since station tile types are no longer limited to the 8 original ones, it's time to implement support for property 0E/0F.
All the basics are validated I think, might need more work to prevent duplicated platform/length combo.
I also force the type to be even without notice.