Remove obsolete try/catch block

OpenTermsArchive · Oct 29, 2024 · 903f399 · 903f399
1 parent 317eaf6
commit 903f399
Showing 1 changed file with 49 additions and 54 deletions.
diff --git a/scripts/reporter/duplicate/index.js b/scripts/reporter/duplicate/index.js
@@ -3,76 +3,71 @@ import config from 'config';
 import { Octokit } from 'octokit';
 
 async function removeDuplicateIssues() {
-  try {
-    const repository = config.get('@opentermsarchive/engine.reporter.githubIssues.repositories.declarations');
+  const repository = config.get('@opentermsarchive/engine.reporter.githubIssues.repositories.declarations');
 
-    if (!repository.includes('/') || repository.includes('https://')) {
-      throw new Error(`Configuration entry "reporter.githubIssues.repositories.declarations" is expected to be a string in the format <owner>/<repo>, but received: "${repository}"`);
-    }
+  if (!repository.includes('/') || repository.includes('https://')) {
+    throw new Error(`Configuration entry "reporter.githubIssues.repositories.declarations" is expected to be a string in the format <owner>/<repo>, but received: "${repository}"`);
+  }
 
-    const [ owner, repo ] = repository.split('/');
+  const [ owner, repo ] = repository.split('/');
 
-    const octokit = new Octokit({ auth: process.env.OTA_ENGINE_GITHUB_TOKEN });
+  const octokit = new Octokit({ auth: process.env.OTA_ENGINE_GITHUB_TOKEN });
 
-    console.log(`Getting issues from repository ${repository}…`);
+  console.log(`Getting issues from repository ${repository}…`);
 
-    const issues = await octokit.paginate('GET /repos/{owner}/{repo}/issues', {
-      owner,
-      repo,
-      state: 'open',
-      per_page: 100,
-    });
+  const issues = await octokit.paginate('GET /repos/{owner}/{repo}/issues', {
+    owner,
+    repo,
+    state: 'open',
+    per_page: 100,
+  });
 
-    const onlyIssues = issues.filter(issue => !issue.pull_request);
-    const issuesByTitle = new Map();
-    let counter = 0;
+  const onlyIssues = issues.filter(issue => !issue.pull_request);
+  const issuesByTitle = new Map();
+  let counter = 0;
 
-    console.log(`Found ${onlyIssues.length} issues`);
+  console.log(`Found ${onlyIssues.length} issues`);
 
-    for (const issue of onlyIssues) {
-      if (!issuesByTitle.has(issue.title)) {
-        issuesByTitle.set(issue.title, [issue]);
-      } else {
-        issuesByTitle.get(issue.title).push(issue);
-      }
+  for (const issue of onlyIssues) {
+    if (!issuesByTitle.has(issue.title)) {
+      issuesByTitle.set(issue.title, [issue]);
+    } else {
+      issuesByTitle.get(issue.title).push(issue);
     }
+  }
 
-    for (const [ title, duplicateIssues ] of issuesByTitle) {
-      if (duplicateIssues.length === 1) continue;
-
-      const originalIssue = duplicateIssues.reduce((oldest, current) => (new Date(current.created_at) < new Date(oldest.created_at) ? current : oldest));
-
-      console.log(`\nFound ${duplicateIssues.length - 1} duplicates for issue #${originalIssue.number} "${title}"`);
-
-      for (const issue of duplicateIssues) {
-        if (issue.number === originalIssue.number) {
-          continue;
-        }
+  for (const [ title, duplicateIssues ] of issuesByTitle) {
+    if (duplicateIssues.length === 1) continue;
 
-        await octokit.request('PATCH /repos/{owner}/{repo}/issues/{issue_number}', { /* eslint-disable-line no-await-in-loop */
-          owner,
-          repo,
-          issue_number: issue.number,
-          state: 'closed',
-        });
+    const originalIssue = duplicateIssues.reduce((oldest, current) => (new Date(current.created_at) < new Date(oldest.created_at) ? current : oldest));
 
-        await octokit.request('POST /repos/{owner}/{repo}/issues/{issue_number}/comments', { /* eslint-disable-line no-await-in-loop */
-          owner,
-          repo,
-          issue_number: issue.number,
-          body: `This issue is detected as duplicate as it has the same title as #${originalIssue.number}. It most likely was created accidentally by an engine older than [v2.3.2](https://github.com/OpenTermsArchive/engine/releases/tag/v2.3.2). Closing automatically.`,
-        });
+    console.log(`\nFound ${duplicateIssues.length - 1} duplicates for issue #${originalIssue.number} "${title}"`);
 
-        counter++;
-        console.log(`Closed issue #${issue.number}: ${issue.html_url}`);
+    for (const issue of duplicateIssues) {
+      if (issue.number === originalIssue.number) {
+        continue;
       }
-    }
 
-    console.log(`\nDuplicate removal process completed; ${counter} issues closed`);
-  } catch (error) {
-    console.log(`Failed to remove duplicate issues: ${error.stack}`);
-    process.exit(1);
+      await octokit.request('PATCH /repos/{owner}/{repo}/issues/{issue_number}', { /* eslint-disable-line no-await-in-loop */
+        owner,
+        repo,
+        issue_number: issue.number,
+        state: 'closed',
+      });
+
+      await octokit.request('POST /repos/{owner}/{repo}/issues/{issue_number}/comments', { /* eslint-disable-line no-await-in-loop */
+        owner,
+        repo,
+        issue_number: issue.number,
+        body: `This issue is detected as duplicate as it has the same title as #${originalIssue.number}. It most likely was created accidentally by an engine older than [v2.3.2](https://github.com/OpenTermsArchive/engine/releases/tag/v2.3.2). Closing automatically.`,
+      });
+
+      counter++;
+      console.log(`Closed issue #${issue.number}: ${issue.html_url}`);
+    }
   }
+
+  console.log(`\nDuplicate removal process completed; ${counter} issues closed`);
 }
 
 removeDuplicateIssues();