Reduce GitHub API calls in issues reporter #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiSG
requested changes
Oct 23, 2024
src/reporter/github.js
Outdated
| } | ||
| } | ||
|
|
||
| async ensureCacheLoaded() { |
There was a problem hiding this comment.
Why not simply await this.cacheLoadedPromise when we call ensureCacheLoaded()? 🙂 Then we don't need to await it in refreshIssuesCache() and we don't need this method.
src/reporter/github.js
Outdated
|
|
||
| return issue; | ||
| getIssue(title) { | ||
| return this.issuesCache.get(title) || null; |
There was a problem hiding this comment.
Why isn't undefined acceptable as a return value if the issue is not found in the cache? 🙂
Suggested change
| return this.issuesCache.get(title) || null; | |
| return this.issuesCache.get(title); |
src/reporter/index.js
Outdated
| @@ -49,6 +49,10 @@ export default class Reporter { | |||
| return this.github.initialize(); | |||
| } | |||
|
|
|||
| onTrackingStarted() { | |||
| return this.github.refreshIssuesCache(); | |||
There was a problem hiding this comment.
Why be eager? Let's just wait until we actually need the cache 🙂
Co-authored-by: Matti Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.