Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable debugging of *github* dep #1801

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

Martii
Copy link
Member

@Martii Martii commented Apr 17, 2021

Applies to #1705

Ref(s):

* Also at some point *node* changed the way to detect if debugging was in process. Updated original comment at OpenUserJS#429 (comment) Been a while since I've been in this mode for deep debug examination.
* Fix missing custom headers for UA. This is optional but didn't know this until now that it had that option for the *github* dep. Post OpenUserJS#1753

Applies to OpenUserJS#1705

Ref(s):
* https://nodejs.org/api/inspector.html#inspector_inspector_url
* https://nodejs.org/api/debugger.html
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Apr 17, 2021
@Martii Martii merged commit 76b5b90 into OpenUserJS:master Apr 17, 2021
@Martii Martii deleted the Issue-1705enableDebuggingRequests branch April 17, 2021 22:38
@Martii
Copy link
Member Author

Martii commented Apr 18, 2021

YAY... sorta... the email notice included the custom UA that was put in here via #1753

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Development

Successfully merging this pull request may close these issues.

1 participant