Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*node* bump #1835

Merged
merged 1 commit into from
Sep 2, 2021
Merged

*node* bump #1835

merged 1 commit into from
Sep 2, 2021

Conversation

Martii
Copy link
Member

@Martii Martii commented Sep 2, 2021

* This finally warns using *npm* under `engines` with *node*
* Also startup with strict instead of lax. Has been in place for about a month as a test for login issues. Still `lax` is needed for OAuth/etc. unfortunately.
* Delete op, sanitize, markdown, moderation flagging, overall UI... retested
* Move git repo linkage in package.json to https. Seems like https://github.blog/2021-09-01-improving-git-protocol-security-github/#how-do-i-prepare with "anonymous" git might be affecting this from what I gather. See also https://docs.npmjs.com/cli/v7/configuring-npm/package-json#git-urls-as-dependencies . Works on current dev stack... haven't ever tried this on pro... so \*crosses things\* Indirectly applies to OpenUserJS#1705 . After March 15, 2022 can retry `git:` but preventative atm.
@Martii Martii added CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration. labels Sep 2, 2021
@Martii Martii merged commit 32b8e2f into OpenUserJS:master Sep 2, 2021
@Martii Martii deleted the nodeMigration branch September 2, 2021 21:39
@Martii
Copy link
Member Author

Martii commented Sep 23, 2021

Further Ref: Cc: @sizzlemctwizzle

I'm not sure what is going to happen when there isn't a token.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Development

Successfully merging this pull request may close these issues.

1 participant