async callback confusion fixed #883 #891
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-baranoff
force-pushed
the
sbaranoff/gh883-async-callback-confusion
branch
6 times, most recently
from
0f3547c to
ff2c278
Compare
added 4 commits
November 4, 2025 20:28
As part of resolving OpenVPN#883 (async netlink message callback confusion on the 2.6 line of code) the changes applied to 2.7 have some major differences to 2.6 that need reconciled first. This back-ports one such necessary change.
As part of resolving OpenVPN#883 (async netlink message callback confusion on the 2.6 line of code) the changes applied to 2.7 have some major differences to 2.6 that need reconciled first. This back-ports one such necessary change.
As part of resolving OpenVPN#883 (async netlink message callback confusion on the 2.6 line of code) the changes applied to 2.7 have some major differences to 2.6 that need reconciled first. This back-ports one such necessary change.
Starting with v2.6.15 tehre were uncrustify changes that needed applied; then there were also differences in dev environments: * Ubuntu 22.04 has 0.72.0_f * Alma 9 has 0.75.1_f and that caused output deltas from uncrustify; so reconcile those to make the build system happy.
stefan-baranoff
force-pushed
the
sbaranoff/gh883-async-callback-confusion
branch
from
ff2c278 to
5789357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion on fixing #883 by back-porting f353b and other required code, which fixed #793 to the OpenVPN 2.6 line. This seems to fix the original issue see in but other issues were uncovered in the process that may apply to 2.6 and 2.7; but I wanted this code to be available in case it's useful.