-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use zero copy between memif and libfabric #237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
Sakoram
force-pushed
the
rdma_zero_cpy
branch
from
October 17, 2024 08:56
f25b8ad
to
a9891c6
Compare
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
ko80
reviewed
Oct 17, 2024
Sakoram
force-pushed
the
rdma_zero_cpy
branch
3 times, most recently
from
October 17, 2024 10:38
8370fb6
to
3ebe16d
Compare
tszumski
reviewed
Oct 17, 2024
tszumski
reviewed
Oct 17, 2024
tszumski
reviewed
Oct 18, 2024
ko80
reviewed
Oct 18, 2024
Sakoram
force-pushed
the
rdma_zero_cpy
branch
from
October 18, 2024 12:02
273b63b
to
acf2c44
Compare
Use memif's buffer to send data directly from them and to receive data directly into them Signed-off-by: Kasiewicz, Marek <[email protected]>
Signed-off-by: Kasiewicz, Marek <[email protected]>
Signed-off-by: Kasiewicz, Marek <[email protected]>
Signed-off-by: Kasiewicz, Marek <[email protected]>
mr_access can be calculated basing on from fi_info stored in libfabric_ctx Signed-off-by: Kasiewicz, Marek <[email protected]>
- In in rdma_get_cq_comp: do not print error if FI_EAVAIL is returned - Return always negative error number Signed-off-by: Kasiewicz, Marek <[email protected]>
Sakoram
force-pushed
the
rdma_zero_cpy
branch
from
October 18, 2024 12:03
acf2c44
to
8904807
Compare
ko80
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Great job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use memif's buffer to send data directly from them and to receive data directly into them
The biggest change is that a new thread was added to TX connection.
The new thread and old frame_thread, both now named ep_thread are responsible for polling completion events from libfabric and returning memif buffer to memif after send/recv was completed.