Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zero copy between memif and libfabric #237

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

Sakoram
Copy link
Collaborator

@Sakoram Sakoram commented Oct 17, 2024

Use memif's buffer to send data directly from them and to receive data directly into them

The biggest change is that a new thread was added to TX connection.
The new thread and old frame_thread, both now named ep_thread are responsible for polling completion events from libfabric and returning memif buffer to memif after send/recv was completed.

media-proxy/src/rdma_session.c Outdated Show resolved Hide resolved
media-proxy/src/rdma_session.c Outdated Show resolved Hide resolved
@Sakoram Sakoram requested a review from ko80 October 17, 2024 10:21
@Sakoram Sakoram force-pushed the rdma_zero_cpy branch 3 times, most recently from 8370fb6 to 3ebe16d Compare October 17, 2024 10:38
@Sakoram Sakoram requested review from tszumski and removed request for Mionsz October 17, 2024 11:03
@Sakoram Sakoram requested a review from tszumski October 17, 2024 14:56
@Sakoram Sakoram requested a review from tszumski October 18, 2024 07:37
Use memif's buffer to send data directly from them
and to receive data directly into them

Signed-off-by: Kasiewicz, Marek <[email protected]>
mr_access can be calculated basing on from fi_info
stored in libfabric_ctx

Signed-off-by: Kasiewicz, Marek <[email protected]>
- In in rdma_get_cq_comp: do not print error if
FI_EAVAIL is returned
- Return always negative error number

Signed-off-by: Kasiewicz, Marek <[email protected]>
Copy link
Collaborator

@ko80 ko80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great job!

@Sakoram Sakoram merged commit ab85760 into OpenVisualCloud:main Oct 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants