-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sj201 v6 and v10 division #32
Conversation
added sj201v10 detection. This helps with plugin validation.
Is this failing because it is from my personal repo? and not from ovos? Regardless, I think this should be merged until we figure out where this code can go. |
i still think these should be defined in the individual plugins and this file deleted from here only the mk2 plugins need to check for a mk2.... doesnt make sense to be in PHAL. also plugins should only need to import from OPM, not from the PHAL code (this is true for all plugins and other services) |
I feel that it should be shared code somewhere in the ovos repos. OPM makes sense to me more than individual packages copying the same thing. This allows for multiple mk2 plug-ins to do an import, instead of duplicating code. |
1 line of code conceptually doesnt fit in OPM repos either, in the sense it is not a shared util for all plugins, same argument done for the led and fan stuff perhaps a dedicated tiny library can be created, just to have the i2c checks available in a single place with 0 dependencies, making it useful also for non OVOS projects etc |
I can go for that for sure |
depreciated detection to move to its own repo |
added sj201v10 detection.
This helps with plugin validation.