Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes and Unit Tests #69

Merged
merged 22 commits into from
Apr 8, 2023
Merged

Bugfixes and Unit Tests #69

merged 22 commits into from
Apr 8, 2023

Commits on Apr 5, 2023

  1. Resolve error relating to #65 

    Adds unit tests for OCP class
    @NeonDaniel
    NeonDaniel committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    28d2d88 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Update logging and docstrings 

    WIP OCPMediaPlayer tests
    @NeonDaniel
    NeonDaniel committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    3c44115 View commit details
    Browse the repository at this point in the history

  2. More unit tests and documentation/code cleanup of player playback met… 

    …hods

Raise an exception if trying to get a stream from nothing
    @NeonDaniel
    NeonDaniel committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    9bd64d3 View commit details
    Browse the repository at this point in the history

  3. Add tests and documentation for pause, resume, seek, and reset methods 

    Add init tests for registered events
Fixes #22 with unit tests for duck/unduck calling pause/resume
    @NeonDaniel
    NeonDaniel committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    b572e22 View commit details
    Browse the repository at this point in the history

  4. Update to handle empty URI per PR feedback

    @NeonDaniel
    NeonDaniel committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    351b807 View commit details
    Browse the repository at this point in the history

  5. Resolving unit test failures

    @NeonDaniel
    NeonDaniel committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    3ed9786 View commit details
    Browse the repository at this point in the history

  6. Resolving unit test failures

    @NeonDaniel
    NeonDaniel committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    55fdc1b View commit details
    Browse the repository at this point in the history

  7. Refactor Message arg per review

    @NeonDaniel
    NeonDaniel committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    cc153cd View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Add tests for handle_player_state_update with handling of int state… 

    … and simplified logic
    @NeonDaniel
    NeonDaniel committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    b62aa78 View commit details
    Browse the repository at this point in the history

  2. Add tests for play_next with updated comments and logging

    @NeonDaniel
    NeonDaniel committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    3435030 View commit details
    Browse the repository at this point in the history

  3. Cleanup and fix bugs in handle_player_media_update with unit test

    @NeonDaniel
    NeonDaniel committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    38f5b3f View commit details
    Browse the repository at this point in the history

  4. Revert equality check per PR review

    @NeonDaniel
    NeonDaniel committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    a0a4acc View commit details
    Browse the repository at this point in the history

  5. Add MediaEntry and Playlist tests and docstrings

    @NeonDaniel
    NeonDaniel committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    fda0473 View commit details
    Browse the repository at this point in the history

  6. Add MediaEntry and Playlist tests

    @NeonDaniel
    NeonDaniel committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    10863ba View commit details
    Browse the repository at this point in the history

  7. Complete media tests and docstrings 

    Split `player` tests to separate test file
    @NeonDaniel
    NeonDaniel committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    4191974 View commit details
    Browse the repository at this point in the history

  8. Ensure MediaEntry.playback is PlaybackType with unit tests 

    Update logging
    @NeonDaniel
    NeonDaniel committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    ed55658 View commit details
    Browse the repository at this point in the history

  9. Fix MessageBusClient import location

    @NeonDaniel
    NeonDaniel committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    b3e738c View commit details
    Browse the repository at this point in the history

  10. Add logging to troubleshoot playback errors

    @NeonDaniel
    NeonDaniel committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    a611375 View commit details
    Browse the repository at this point in the history

  11. Update logging to troubleshoot

    @NeonDaniel
    NeonDaniel committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    aef12d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2023

  1. Refactor NowPlaying reset and update unit tests

    @NeonDaniel
    NeonDaniel committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    434a28a View commit details
    Browse the repository at this point in the history

  2. Update test to handle refactored reset calls

    @NeonDaniel
    NeonDaniel committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    f2d1981 View commit details
    Browse the repository at this point in the history

  3. Update 'play_next' based on PR conversation

    @NeonDaniel
    NeonDaniel committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    17a1043 View commit details
    Browse the repository at this point in the history