Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GUI to pass resource names instead of paths #90

Merged
merged 9 commits into from
Jul 19, 2023

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Jul 18, 2023

Update GUI references to use names instead of file paths for container support
Add qmldir to GUI resource directories for server support
Includes unit test patches for yaml/pyyaml#724

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@bcec129). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev      #90   +/-   ##
======================================
  Coverage       ?   53.20%           
======================================
  Files          ?       13           
  Lines          ?     2633           
  Branches       ?        0           
======================================
  Hits           ?     1401           
  Misses         ?     1232           
  Partials       ?        0           

@NeonDaniel
Copy link
Member Author

This still does not make OCP usable with http-served files, relating to OpenVoiceOS/ovos-gui#19
This does fix path resolution though, so remaining issues are related to the GUI client/implementation-specific

@NeonDaniel NeonDaniel requested a review from a team July 18, 2023 22:27
@NeonDaniel NeonDaniel marked this pull request as ready for review July 18, 2023 22:27
@NeonDaniel NeonDaniel merged commit e8b1fd6 into dev Jul 19, 2023
@NeonDaniel NeonDaniel deleted the FEAT_UIResourceResolution branch July 19, 2023 21:44
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant