Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PlaybackType.SKILL search results to be played when there is no GUI #95

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

Ramblurr
Copy link
Contributor

As described in #92, this commit permits search results of PlaybackType.SKILL to be played when there is no GUI. The skill handles playback itself and may not need a GUI.

fixes #92

…no GUI

As described in OpenVoiceOS#92, this commit permits search results of `PlaybackType.SKILL`
to be played when there is no GUI. The skill handles playback itself and
may not need a GUI.

fixes OpenVoiceOS#92
@JarbasAl JarbasAl added the bug Something isn't working label Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@b26f4fa). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev      #95   +/-   ##
======================================
  Coverage       ?   53.20%           
======================================
  Files          ?       13           
  Lines          ?     2633           
  Branches       ?        0           
======================================
  Hits           ?     1401           
  Misses         ?     1232           
  Partials       ?        0           

@JarbasAl JarbasAl merged commit 50f7a8b into OpenVoiceOS:dev Aug 21, 2023
10 checks passed
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCP skills supporting PlaybackType.SKILL cannot be played when there is no GUI
2 participants