Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/optional_g2p #169

Merged
merged 1 commit into from
Jul 4, 2023
Merged

feat/optional_g2p #169

merged 1 commit into from
Jul 4, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Jul 4, 2023

do not fail if g2p is not loaded, it is an optional component

do not fail if g2p is not loaded, it is an optional component
@JarbasAl JarbasAl added the bug Something isn't working label Jul 4, 2023
@JarbasAl JarbasAl requested review from NeonDaniel, builderjer and a team July 4, 2023 22:11
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@8e5b3c5). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev    #169   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      56           
  Lines          ?    3974           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    3974           
  Partials       ?       0           

@JarbasAl JarbasAl merged commit aeb765c into dev Jul 4, 2023
10 checks passed
@JarbasAl JarbasAl deleted the feat/optional_g2p branch July 4, 2023 22:14
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant