feat/ovos_dialog_tts_transformers #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
listener has AudioTransformers core has MetadataTransformers and UtteranceTransformers this PR extends the concept to ovos-audio for text before TTS stage, and wav file after TTS but before playback use case demonstration https://gist.github.com/JarbasAl/16788bdcff3fa5bfb3634d6f2116cc04 this ties into OpenVoiceOS/ovos-persona#4
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #179 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 57
Lines ? 3915
Branches ? 0
=====================================
Hits ? 0
Misses ? 3915
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Closed
This was referenced Oct 6, 2023
JarbasAl
added
enhancement
mikejgray
reviewed
Oct 7, 2023
|
Oh, and the tests. Need fixing/coverage 🙂 |
NeonDaniel
reviewed
Oct 10, 2023
| from ovos_audio.playback import PlaybackThread | ||
| return PlaybackThread(*args, **kwargs) | ||
| except ImportError: | ||
| raise ImportError("please install ovos-audio for playback handling") |
There was a problem hiding this comment.
This import error is being thrown with ovos-audio 0.0.2a13 installed
There was a problem hiding this comment.
0.0.2a19 is the min version needed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listener has AudioTransformers
core has MetadataTransformers and UtteranceTransformers
this PR extends the concept to ovos-audio for text before TTS stage, and wav file after TTS but before playback
this ties into OpenVoiceOS/ovos-persona#4
DialogTransformer example OpenVoiceOS/ovos-solver-openai-persona-plugin#2
TTSTransformer example https://github.com/OpenVoiceOS/ovos-tts-transformer-sox-plugin/