feat/restore phonetic spellings #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #195 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 57
Lines ? 3972
Branches ? 0
=====================================
Hits ? 0
Misses ? 3972
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mikejgray
reviewed
Dec 9, 2023
JarbasAl
force-pushed
the
refactor/rm_cache
branch
from
19330e1
to
7eb3f03
Compare
fix kwargs handling in synth method move methods around for readability and group them based on functionality add more deprecation warnings lang from session move cache to TTSContext
JarbasAl
force-pushed
the
refactor/rm_cache
branch
from
7030feb
to
3bcfaf9
Compare
JarbasAl
force-pushed
the
refactor/rm_cache
branch
from
094a541
to
e8b6066
Compare
JarbasAl
added a commit
to OpenVoiceOS/ovos-audio
that referenced
this pull request
Apr 21, 2024
A hivemind satellite can listen for `speak` messages from master, emit 'speak:b64_audio', and listen for 'speak:b64_audio.response' with b64 encoded audio to play. eg, in a browser counterpart to OpenVoiceOS/ovos-dinkum-listener#75 needs OpenVoiceOS/ovos-plugin-manager#195
JarbasAl
added a commit
to OpenVoiceOS/ovos-audio
that referenced
this pull request
Apr 21, 2024
A hivemind satellite can listen for `speak` messages from master, emit 'speak:b64_audio', and listen for 'speak:b64_audio.response' with b64 encoded audio to play. eg, in a browser counterpart to OpenVoiceOS/ovos-dinkum-listener#75 needs OpenVoiceOS/ovos-plugin-manager#195
|
used to refer to a hardcoded nglish file in mycroft-core specific to mimic1 now generalized to be per TTS plugin and live in a "locale" folder like everything else
JarbasAl
added a commit
to OpenVoiceOS/ovos-audio
that referenced
this pull request
Apr 25, 2024
remove all references to self.tts within the playback thread to simplify code, this does not break mycroft module compat as it was not present there needs OpenVoiceOS/ovos-plugin-manager#195 for the cache cleaning
JarbasAl
added a commit
to OpenVoiceOS/ovos-audio
that referenced
this pull request
Apr 25, 2024
remove all references to self.tts within the playback thread to simplify code, this does not break mycroft module compat as it was not present there needs OpenVoiceOS/ovos-plugin-manager#195 for the cache cleaning
JarbasAl
added a commit
to OpenVoiceOS/ovos-tts-plugin-mimic
that referenced
this pull request
Apr 25, 2024
JarbasAl
added a commit
to OpenVoiceOS/ovos-tts-plugin-mimic
that referenced
this pull request
Apr 26, 2024
fixed by OpenVoiceOS/ovos-audio#59 |
JarbasAl
added a commit
to OpenVoiceOS/ovos-audio
that referenced
this pull request
Apr 29, 2024
* refactor/revert_ovos_additions_to_playback_thread remove all references to self.tts within the playback thread to simplify code, this does not break mycroft module compat as it was not present there needs OpenVoiceOS/ovos-plugin-manager#195 for the cache cleaning * allow older OPM versions * allow older OPM versions
JarbasAl
added a commit
to OpenVoiceOS/ovos-audio
that referenced
this pull request
Apr 29, 2024
* feat/b64_tts A hivemind satellite can listen for `speak` messages from master, emit 'speak:b64_audio', and listen for 'speak:b64_audio.response' with b64 encoded audio to play. eg, in a browser counterpart to OpenVoiceOS/ovos-dinkum-listener#75 needs OpenVoiceOS/ovos-plugin-manager#195 * Update ovos_audio/service.py Co-authored-by: Mike <[email protected]> * Update requirements.txt --------- Co-authored-by: Mike <[email protected]>
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phonetic spellings used to refer to a hardcoded english file in mycroft-core specific to mimic1
now generalized to be per TTS plugin and live in a "locale" folder like everything else
example: OpenVoiceOS/ovos-tts-plugin-mimic#12
per lang/request support for phonetic-spellings 🎉
TTSContext has also been extended to fully encapsulate the request specific data (lang/voice/synth_kwargs)
TTS base class was cleaned up in the process