Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port unittests from workshop #199

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

port unittests from workshop #199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67b0b86
port unittests from workshop
JarbasAl Dec 29, 2023
3c0e105
Update test_skills.py
JarbasAl Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions test/unittests/test_skills.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from unittest.mock import patch

from ovos_plugin_manager.utils import PluginTypes, PluginConfigTypes
from ovos_plugin_manager.skills import get_skill_directories, get_default_skills_directory


class TestSkills(unittest.TestCase):
Expand All @@ -16,6 +17,34 @@ def test_find_plugins(self, find_plugins):
find_skill_plugins()
find_plugins.assert_called_once_with(self.PLUGIN_TYPE)


def test_get_skill_directories(self):
# Default directory
mock_config = {'skills': {}}
default_directories = get_skill_directories(mock_config)
for directory in default_directories:
self.assertEqual(basename(directory), 'skills')
# Configured directory
mock_config['skills']['directory'] = 'test'
test_directories = get_skill_directories(mock_config)
for directory in test_directories:
self.assertEqual(basename(directory), 'test')
self.assertEqual(len(default_directories), len(test_directories))

def test_get_default_skills_directory(self):
# Default directory
mock_config = {'skills': {}}
default_dir = get_default_skills_directory(mock_config)
self.assertTrue(isdir(default_dir))
self.assertEqual(basename(default_dir), 'skills')
self.assertEqual(dirname(dirname(default_dir)), self.test_data_path)
# Override directory
mock_config['skills']['directory'] = 'test'
test_dir = get_default_skills_directory(mock_config)
self.assertTrue(isdir(test_dir))
self.assertEqual(basename(test_dir), 'test')
self.assertEqual(dirname(dirname(test_dir)), self.test_data_path)

def test_load_skill_plugins(self):
from ovos_plugin_manager.skills import load_skill_plugins
# TODO
Loading