Skip to content

Match class & file name for Solaris Filesystems #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

Conversation

smortex
Copy link
Member

@smortex smortex commented Jun 17, 2025

The filename was plural but the class name was inconsistently singular.
Other resolvers / facts seems to consistently use plural, so pluralize
the class name ta match the file name.

The filename was plural but the class name was inconsistently singular.
Other resolvers / facts seems to consistently use plural, so pluralize
the class name ta match the file name.
@smortex smortex added the backwards-incompatible This change will lead to a major version bump for the next release label Jun 26, 2025
Copy link
Contributor

@jessereynolds jessereynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency FTW. Also, needed for the approach in #16 I believe

@smortex smortex merged commit 9a23605 into main Jun 26, 2025
16 checks passed
@smortex smortex deleted the solaris-filesystems branch June 26, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatible This change will lead to a major version bump for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants