Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pump efficiency functions. #815

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add pump efficiency functions. #815

wants to merge 1 commit into from

Conversation

cameron-devine
Copy link

No description provided.

@samhatchett samhatchett self-requested a review October 2, 2024 14:52
@samhatchett
Copy link
Member

thanks @cameron-devine. This was probably an oversight when we added the head curve functions.

@LRossman
Copy link
Collaborator

LRossman commented Oct 2, 2024

Isn't this functionality already present using EN_getlinkvalue and EN_setlinkvalue with EN_PUMP_ECURVE as a parameter? Likewise the existing EN_getheadcurveindex and EN_setheadcurveindex functions are redundant since the same can be accomplished using EN_getlinkvalue and EN_setlinkvalue with EN_PUMP_HCURVE as a parameter.

@samhatchett
Copy link
Member

@LRossman oh, interesting. that sounds right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samhatchett samhatchett Awaiting requested review from samhatchett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cameron-devine @samhatchett @LRossman