(feat) add supplier selection #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdhoek1
force-pushed
the
feat/idp-userdata-2
branch
from
1933de0 to
ac57443
Compare
mvdhoek1
force-pushed
the
feat/idp-userdata-2
branch
from
ac57443 to
9442c4a
Compare
mvdhoek1
approved these changes
Dec 11, 2024
| @@ -38,4 +39,17 @@ public function getResponse(): ?Response | |||
| { | |||
| return $this->response; | |||
| } | |||
|
|
|||
| protected function formatResponse(array $json): string | |||
There was a problem hiding this comment.
Discutabel deze method maar Procura gebruikt geen 'title' en 'detail' in hun response wanneer er een fout optreedt. Ik ga dit bij hen aangeven maar betwijfel of zij dit gaan aanpassen.
There was a problem hiding this comment.
Dan voldoen ze niet aan de ZGW standaard.
Zie ook: https://vng-realisatie.github.io/gemma-zaken/standaard/zaken/swagger-ui-1.5.1#model-Fout
There was a problem hiding this comment.
Klopt dit heb ik aangegeven met als antwoord: Hoe graag ik het ook zou willen, maar dit kunnen wij niet op korte termijn aanpassen.
Ik haal de method wel weg zodra ik kan mergen, voor nu is ie handig om te debuggen.
robertbossaert
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maar het meest belangrijke, op basis van de leverancier selectie in de algemene instellingen wordt op de pagina 'formulier instellingen' alleen de zaaktypen en informatieobject typen van de geselecteerde leveranciers opgehaald.