Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler warnings elimination #713

Open
5 of 25 tasks
Xottab-DUTY opened this issue Jan 8, 2021 · 1 comment · Fixed by #766, #1040, #1022, #1275 or #1486
Open
5 of 25 tasks

Compiler warnings elimination #713

Xottab-DUTY opened this issue Jan 8, 2021 · 1 comment · Fixed by #766, #1040, #1022, #1275 or #1486
Assignees
@Masterkatze
Labels
Code Quality Help wanted Portability
Milestone
Warnings elimination

Comments

@Xottab-DUTY
Copy link
Member

Xottab-DUTY commented Jan 8, 2021 •
edited
Loading

Starting from the creation of this task, #116 is a subtask of this task.

MSVC:

  • MSBuild
    • Enable "warnings are errors" mode (is it possible?)
  • Compiler
    • Enable conformance mode
    • Enable "warnings are errors" mode
    • Raise the warning level to 4
      • Level 1
      • Level 2
      • Level 3
      • Level 4
  • Linker
    • Enable "warnings are errors" mode

GCC:

  • CMake and make
    • Enable "warnings are errors" mode (is it possible?)
  • Compiler
    • Disable permissive mode
    • Maybe enable pedantic mode
    • Enable "warnings are errors" mode
    • Raise the warning level to 4
      • Level 1
      • Level 2
      • Level 3
      • Level 4
  • Linker
    • Enable "warnings are errors" mode

For history:

  • List all warnings elimination commits in this issue

Tools:
PVS-Studio
CppDepend (includes cppcheck, Clang-Tidy, Vera++)
ReSharper C++ (includes Clang and Clang-Tidy check plus it's own analysis)
Visual Assist (has it's own code inspection)

https://habr.com/ru/articles/75123/
https://habr.com/ru/companies/pvs-studio/articles/303664/
@Xottab-DUTY Xottab-DUTY added this to the Warnings elimination milestone Jan 8, 2021
@Xottab-DUTY Xottab-DUTY mentioned this issue Jan 8, 2021
Open
@Xottab-DUTY Xottab-DUTY changed the title Code quality control Compiler warnings elimination Jan 13, 2021
@Xottab-DUTY Xottab-DUTY mentioned this issue Jan 18, 2021
Merged
@Xottab-DUTY Xottab-DUTY mentioned this issue Jul 14, 2021
Closed
@Xottab-DUTY
Copy link
Member Author

Some work:
64ab9ce
5460f48

This was linked to pull requests Apr 29, 2023
Fix almost all -Wall warnings #907
Closed
Fix some build warnings #766
Merged
Fix build warnings in src/Layers #1040
Merged
Fix build warnings in src/xrCore and src/Common #1022
Merged
Fix build warnings in src/xrGame #1275
Merged
Xottab-DUTY added a commit that referenced this issue Apr 29, 2023
@Xottab-DUTY
MSBuild: disable warnings for external dependencies (#713)
21009ea
Xottab-DUTY added a commit that referenced this issue Apr 30, 2023
@Xottab-DUTY
xrParticles: Fixed MSVC W3-level warnings (#713)
d51d49d
Xottab-DUTY added a commit that referenced this issue Apr 30, 2023
@Xottab-DUTY
xrXRC::count now returns size_t (#713)
f5771da
Xottab-DUTY added a commit that referenced this issue Apr 30, 2023
@Xottab-DUTY
xrSound: Fixed MSVC W3-level warnings (#713)
9a56162
Xottab-DUTY added a commit that referenced this issue Apr 30, 2023
@Xottab-DUTY
xrEngine: fixed few MSVC W3 warnings (#713)
bba380b
Xottab-DUTY added a commit that referenced this issue Apr 30, 2023
@Xottab-DUTY
xrUICore: fixed few MSVC W3 warnings (#713)
17814d0
Xottab-DUTY added a commit that referenced this issue Apr 30, 2023
@Xottab-DUTY
Optimize and modernize shared_str and ref_smem (#713)
8a3c992
@Xottab-DUTY Xottab-DUTY moved this to In Progress in Roadmap Nov 15, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Nov 15, 2023
@Xottab-DUTY Xottab-DUTY reopened this Nov 15, 2023
@Xottab-DUTY Xottab-DUTY moved this from Done to In Progress in Roadmap Nov 15, 2023
@Xottab-DUTY Xottab-DUTY linked a pull request Nov 15, 2023 that will close this issue
Fix Wimplicit-fallthrough warnings (#713) #1498
Merged
@Xottab-DUTY Xottab-DUTY removed a link to a pull request Nov 15, 2023
Fix Wimplicit-fallthrough warnings (#713) #1498
Merged
@Xottab-DUTY Xottab-DUTY linked a pull request Nov 15, 2023 that will close this issue
Fix Wunused-variable warnings (#713) #1486
Merged
Xottab-DUTY pushed a commit that referenced this issue Nov 29, 2023
@AMS21
Fix Wimplicit-fallthrough warnings (#713) (#1498)
bde2029
@Xottab-DUTY Xottab-DUTY mentioned this issue Mar 2, 2024
Closed
alsed added a commit to alsed/xray-16 that referenced this issue Dec 21, 2024
@alsed
Resolves several compile warnings when comparing different int signed…
c8066e9 
…ness (2)

- advances OpenXRay#713 and eliminates all warnings concerning this operation:
- in R_dsgraph_structure::load() / r__dsgraph_build.cpp
- var 'vcnt' converted to u32 in R_Backend_DBG.cpp
- several for loops in light.cpp
- several for loops in in DetailManager_CACHE.cpp
- var 'filled_blocks' converted from int to i32, in SoundRender_Emitter.cpp
- in CSoundRender_Core::create() / SoundRender_Core.cpp,
explicit convertion of var 'sg_SourceType' to int
- for loop in CollectorPacked::CollectorPacked() / xrCDB_Collector.cpp
- several for loops in Frustum.cpp
@alsed alsed mentioned this issue Dec 21, 2024
Merged
@Xottab-DUTY Xottab-DUTY moved this from In Progress to To do in Roadmap Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Masterkatze Masterkatze

Labels
Code Quality Help wanted Portability
Projects
Roadmap
Status: To do
Milestone
Warnings elimination
2 participants
@Xottab-DUTY @Masterkatze