Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix almost all -Wall warnings #907

Closed
wants to merge 1 commit into from

Conversation

Masterkatze
Copy link
Contributor

No description provided.

src/xrCDB/xrCDB.cpp Outdated Show resolved Hide resolved
src/xrGame/PdaMsg.h Outdated Show resolved Hide resolved
@Xottab-DUTY Xottab-DUTY force-pushed the dev branch 2 times, most recently from 2fd8eb8 to a16bebe Compare December 4, 2021 11:38
@Masterkatze Masterkatze force-pushed the warnings branch 2 times, most recently from 3d7fd34 to 95237c9 Compare December 6, 2021 00:51
@OPNA2608
Copy link
Contributor

OPNA2608 commented Jan 7, 2022

Errors on my end, x86_64 Linux w/ GCC10 (and 9):

[ 10%] Building CXX object src/xrCore/CMakeFiles/xrCore.dir/FS.cpp.o
/build/source/src/xrCore/FS.cpp: In function 'void FileCompress(pcstr, pcstr, void*, size_t)':
/build/source/src/xrCore/FS.cpp:172:11: error: ignoring return value of 'ssize_t write(int, const void*, size_t)' declared with attribute 'warn_unused_result' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-result-Werror=unused-result8;;]
  172 |     _write(H, &M, 8);
      |           ^
/build/source/src/xrCore/FS.cpp: In function 'void* FileDecompress(pcstr, pcstr, size_t*)':
/build/source/src/xrCore/FS.cpp:184:10: error: ignoring return value of 'ssize_t read(int, void*, size_t)' declared with attribute 'warn_unused_result' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-result-Werror=unused-result8;;]
  184 |     _read(H, &F, 8);
      |          ^
cc1plus: all warnings being treated as errors
make[2]: *** [src/xrCore/CMakeFiles/xrCore.dir/build.make:237: src/xrCore/CMakeFiles/xrCore.dir/FS.cpp.o] Error 1

@Masterkatze Masterkatze force-pushed the warnings branch 7 times, most recently from 8a28c0a to 9bb27c1 Compare May 4, 2022 22:36
@Masterkatze
Copy link
Contributor Author

@OPNA2608 Hi, sorry for such late answer, can you try it now?

@OPNA2608
Copy link
Contributor

OPNA2608 commented May 7, 2022

Doesn't error anymore, but some warnings remain on my end. Here's the build log.

@Masterkatze
Copy link
Contributor Author

Случайно закрыл

@Xottab-DUTY Xottab-DUTY force-pushed the dev branch 2 times, most recently from 7d4c1cd to dd2f60a Compare April 14, 2023 12:47
@Xottab-DUTY Xottab-DUTY added this to the Warnings elimination milestone Apr 29, 2023
@Xottab-DUTY Xottab-DUTY linked an issue Apr 29, 2023 that may be closed by this pull request
25 tasks
@Xottab-DUTY
Copy link
Member

Since you have submitted a major number of changes from this PR in separate PRs, let's close it to reduce the number of pull requests. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler warnings elimination
3 participants