Generalize bug fix from #1512 #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMS21
force-pushed
the
generalize_1512
branch
2 times, most recently
from
4b4430a to
0682393
Compare
375gnu
reviewed
Nov 15, 2023
| // Linux 'read' function can return less then the requested number of bytes and might need to be called multiple times. | ||
| // Apart from this, it behaves exactly as you would expect and matches the other OSes implementation. | ||
| // See also: https://www.man7.org/linux/man-pages/man2/read.2.html | ||
| inline ssize_t xr_read(int file_handle, void *buffer, size_t count) |
There was a problem hiding this comment.
Actually it make sense to make this implementation common, so any new platform with such behaviour will be handled automatically. And it will not harm other platforms.
There was a problem hiding this comment.
Alright where would be a good place to put this? Directly into Platform.h?
Xottab-DUTY
added
Enhancement
Portability
Code Quality
Developer Experience
AMS21
force-pushed
the
generalize_1512
branch
from
0682393 to
127e8ee
Compare
AMS21
force-pushed
the
generalize_1512
branch
from
127e8ee to
210ef94
Compare
Xottab-DUTY
approved these changes
Nov 29, 2023
Xottab-DUTY
added a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more generalized solution to the bug fix described in #1512 which requires less
#ifdefand allows other places to also benefit from this fix.