Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OXT-1383: idl: Add VirtType to support PVH #30

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

jandryuk
Copy link
Contributor

@jandryuk jandryuk commented Aug 1, 2018

HVM as a boolean cannot express PVH. Switch to the new VIRT_TYPE enum
to support PVH along with PV and HVM.

OXT-1383

Signed-off-by: Jason Andryuk [email protected]

HVM as a boolean cannot express PVH.  Switch to the new VIRT_TYPE enum
to support PVH along with PV and HVM.

OXT-1383

Signed-off-by: Jason Andryuk <[email protected]>
@jean-edouard
Copy link
Member

@jean-edouard
Copy link
Member

@jean-edouard
Copy link
Member

This PR, along with OpenXT/manager#125 and OpenXT/toolstack-data#49 adds the PVH option to our IDL, toolstack and UI.
I tested and made sure that the option was present in the UI and properly propagated to xenmgr and xl.
Testing actual PVH guests is out of the scope here.
Therefore: LGTM, merging tomorrow.

@jean-edouard jean-edouard merged commit d1c940a into OpenXT:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants